Polls Functionality #3
Conversation
|
I tested this out and looked at the code and it turns out anyone can vote any number of times, might want to add a HashSet of user IDs or something to make sure people can only vote once. |
|
@amccarthy1 Hah, thanks. I wrote this late at night... what a huge oversight. I'll do something like that. |
src/Poll.java
Outdated
| } | ||
|
|
||
| if (voteKey != 0) { | ||
| votes[voteKey-1] = votes[voteKey-1] + 1; |
There was a problem hiding this comment.
This throws an ArrayIndexOutOfBoundsException for negative values or values greater than the number of options (which happens quite a lot in twitch chat). The exception is caught and not logged or anything but you should still probably do bounds checking to handle that a little more gracefully.
|
@amccarthy1 Fixed in latest commit. Went with another HashMap for the user votes, similar to what I am doing in Also changed the input matching to split on commas, which should make it easier to do something like: Let me know if you see any other issues, and appreciate the review. Should be a lot better now, though I'm still not testing thoroughly :P |
2 participants
Sorry this PR is messy, and might be hard to follow. Really just pay attention to changes in
Poll.javaandConnection.java. Make sure you re-disable any bot listeners you do not want active.Upgrade to Pircxbot 2.1 if you are going to keep the new server connection strategy with
addServerandsetServerPassword. Otherwise keep the current strategy ofsetServeras it is now.!poll option1 option2 option3(space separated options)!pollto end the poll